Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RotatedAxisLabelSample: Disable AutoRanging #628

Merged
merged 1 commit into from
Sep 29, 2023
Merged

RotatedAxisLabelSample: Disable AutoRanging #628

merged 1 commit into from
Sep 29, 2023

Conversation

wirew0rm
Copy link
Member

Having autoranging enabled on synchronized axes with bound min/max properties results in errors when the bound properties are modified by the autoraning algorithm.

Having autoranging enabled on synchronized axes with bound min/max
properties results in errors when the bound properties are modified by
the autoraning algorithm.
@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9e84290) 48.07% compared to head (00689b9) 48.07%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #628   +/-   ##
=========================================
  Coverage     48.07%   48.07%           
- Complexity     6218     6222    +4     
=========================================
  Files           374      374           
  Lines         38304    38304           
  Branches       6117     6117           
=========================================
  Hits          18416    18416           
- Misses        18728    18729    +1     
+ Partials       1160     1159    -1     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ennerf ennerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going forward the min/max/tickUnit properties should be ReadOnly similar to the scale and length parameters.

@wirew0rm wirew0rm merged commit 32fc435 into main Sep 29, 2023
12 checks passed
@wirew0rm wirew0rm deleted the smallFixes branch September 29, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants